[RFC] Certs and Creds from a managed smart subtransport #1178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmn
force-pushed
the
cmn/subtransport-owner
branch
from
bebede8 to
5b6bea0
Compare
carlosmn
changed the title
Implement a method for a smart subtransport implementation ask the caller for what credentials to use. The certificate callback is also here, but untested as the web requests go to the central service point instead of asking individually.
carlosmn
force-pushed
the
cmn/subtransport-owner
branch
from
5b6bea0 to
c3a3be5
Compare
|
I'm merging this since it's all new functionality so existing code will still work, and we can still try to figure out if something isn't quite right with the code in mainline. |
carlosmn
added a commit
that referenced
this pull request
Feb 26, 2016
[RFC] Certs and Creds from a managed smart subtransport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not ask for credentials or confirm server certs via the libgit2 channel; the implementation we know of wants to bypass libgit2 for these things. Which is fine, but if we want a managed implementation to behave like the built-in ones, we also need to let the subtransport ask for them.
This is an attempt at such an implementation. Basically nothing is final, but I'd like to know what we consider best to deal with return codes coming from the callbacks. We might be able to punt and say that we only support whatever libgit2sharp itself would return, so maybe we don't have to deal with
PASSTHROUGHif we never generate it.This depends on updated libgit2 binaries.