Obsolete the config paths in RepositoryOptions #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now isolate all tests by setting the config search paths globally at the start of the fixture.
We set a dummy user name and email in the global configuration through the options. Move away from this obsoleted method and set the configuration at the repo level, which is where a test-specific configuration should live.
These tests use the option to set a global configuration file with the filemode we want. But the filemode setting should be set per-repository as it comes down to the workdir for each repository. Switch to setting the configuration in the local configuration, which is also more in line with how it would exist in the wild.
carlosmn
force-pushed
the
cmn/obsolete-repo-config-paths
branch
from
512ab1c to
4924146
Compare
|
The failing test succeeds if I add code to read from |
|
Looks like it was indeed the ProgramData level. For extra fun, if you access |
carlosmn
force-pushed
the
cmn/obsolete-repo-config-paths
branch
from
44b7385 to
ebc43b4
Compare
|
It turns out that teaching it about ProgramData in two different PRs gets awkward, so I just did it here. |
ethomson
pushed a commit
that referenced
this pull request
Mar 17, 2016
Obsolete the config paths in RepositoryOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage in our test suite seems rather gratuitous, and most of the config would have been more at home in the local configuration.
Fixes #1188