-
Notifications
You must be signed in to change notification settings - Fork 899
Update test project dependencies #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Marking as [WIP] until I get the CI builds sorted out. Need to get them to use a newer version of NuGet. |
LibGit2Sharp/LibGit2Sharp.csproj
Outdated
@@ -11,7 +11,7 @@ | |||
<AppDesignerFolder>Properties</AppDesignerFolder> | |||
<RootNamespace>LibGit2Sharp</RootNamespace> | |||
<AssemblyName>LibGit2Sharp</AssemblyName> | |||
<TargetFrameworkVersion>v4.0</TargetFrameworkVersion> | |||
<TargetFrameworkVersion>v4.6</TargetFrameworkVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to revert this. We can target net40 in the library and target net46 in the test project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, that should be possible. Once I finally get the tests working on Travis, I'll go back and change that back.
becda06
to
ed73084
Compare
Use latest instead
It doesn't seem to be able to properly cast the data for destPaths to IEnumerable<string>.
ed73084
to
a63e81c
Compare
And we're green! I had to disable xUnit 2.x's test parallelization because it was causing file locking conflicts. It would be worth revisiting this in the future to speed up the test runs. I also had to change up some tests that were using the |
Thanks! |
As part of preparing for #1318, this updates the unit test dependencies to the latest versions, which support .NET Standard targets.