Skip to content

Update test project dependencies #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 2, 2017
Merged

Update test project dependencies #1431

merged 13 commits into from
Apr 2, 2017

Conversation

bording
Copy link
Member

@bording bording commented Apr 1, 2017

As part of preparing for #1318, this updates the unit test dependencies to the latest versions, which support .NET Standard targets.

@bording bording changed the title Update test project dependencies [WIP] Update test project dependencies Apr 1, 2017
@bording
Copy link
Member Author

bording commented Apr 1, 2017

Marking as [WIP] until I get the CI builds sorted out. Need to get them to use a newer version of NuGet.

@@ -11,7 +11,7 @@
<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>LibGit2Sharp</RootNamespace>
<AssemblyName>LibGit2Sharp</AssemblyName>
<TargetFrameworkVersion>v4.0</TargetFrameworkVersion>
<TargetFrameworkVersion>v4.6</TargetFrameworkVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to revert this. We can target net40 in the library and target net46 in the test project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, that should be possible. Once I finally get the tests working on Travis, I'll go back and change that back.

@bording bording force-pushed the bording/update-tests branch from becda06 to ed73084 Compare April 1, 2017 21:21
@bording bording force-pushed the bording/update-tests branch from ed73084 to a63e81c Compare April 1, 2017 21:32
@bording
Copy link
Member Author

bording commented Apr 1, 2017

And we're green!

I had to disable xUnit 2.x's test parallelization because it was causing file locking conflicts. It would be worth revisiting this in the future to speed up the test runs.

I also had to change up some tests that were using the InlineData attribute to pass in IEnumerable<string> values. On mono, it was failing with a error about not being able to convert from System.Object[] to IEnumerable<string>.

@bording bording changed the title [WIP] Update test project dependencies Update test project dependencies Apr 1, 2017
@bording bording merged commit 2a8b1f0 into master Apr 2, 2017
@bording bording deleted the bording/update-tests branch April 2, 2017 00:45
@bording bording mentioned this pull request Apr 2, 2017
@AArnott
Copy link
Contributor

AArnott commented Apr 2, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants