Update libgit2 to 2ca088b #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tag names are now recorded in the reflog without a leading `refs/tags/`, beginning in libgit2/libgit2#4174
bording
reviewed
Jun 13, 2017
LibGit2Sharp/packages.config
Outdated
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <packages> | |||
| <package id="LibGit2Sharp.NativeBinaries" version="1.0.165" targetFramework="net40" allowedVersions="[1.0.165]" /> | |||
| </packages> | |||
| <package id="LibGit2Sharp.NativeBinaries" version="1.0.183" targetFramework="net40" /> | |||
There was a problem hiding this comment.
You're missing the allowedVersions attribute here.
ethomson
force-pushed
the
ethomson/update_libgit2
branch
from
a695fd5 to
276ac15
Compare
|
Hmm. Looks like the Unix platforms aren't loading their native libraries... they're in the nuget and, from the logs, it looks like they're getting deployed correctly. @bording any ideas why this might happen? |
|
Hmm, Travis is currently configured to use the latest version of mono, which is now 5.0. I know it was working fine with 4.8, so maybe try modifying the Travis config to run against 4.8 and see if that's what has changed? |
|
Huh. Good call! |
|
So now the question is what changed in 5.0 to break this? I'll play around with it a bit to try and figure out what the problem is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.