nuget: don't try to find msbuild (incorrectly) #1458
Merged
+1
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the changes in the way MSBuild is bundled and installed in Visual Studio 2015+, we can no longer use the old hacky way to find where msbuild is installed. This busted AppVeyor whose image has VS 2015 installed and an old (incompatible) version of msbuild installed elsewhere. We would find only the old version. Require nuget package users to have msbuild in their path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes in the way MSBuild is bundled and installed in Visual
Studio 2015+, we can no longer use the old hacky way to find where
msbuild is installed.
This busted AppVeyor whose image has VS 2015 installed and an old
(incompatible) version of msbuild installed elsewhere. We would find
only the old version.
Require nuget package users to have msbuild in their path.