Exposed git_merge_base as CommitCollection.GetCommonAncestor(...) #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated libgit2 to 54695f4098c75801f477f5bc229a52653484e08a Updated libgit2 error codes to prevent test failures. Renamed git_lasterror to giterr_last (per libgit2)
|
This currently fails some tests, I suspect that's due to the libgit2 update, investigating. |
|
Unable to get the GitError working, there's also a few other failing tests due to the libgit2 update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make this work, I had to update libgit2 (to 54695f4098c75801f477f5bc229a52653484e08a)
When I did that I had to rename git_lasterror to giterr_last. I also had to edit some of the error codes to make sure they matched the codes given in errors.h.