Skip to content

Use FilePath in TreeChanges #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use FilePath in TreeChanges #171

wants to merge 1 commit into from

Conversation

nulltoken
Copy link
Member

Under the hood, TreeChanges should leverage FilePath for all paths.

@nulltoken
Copy link
Member

Would this do it?

@nulltoken
Copy link
Member

Could use Path.Combine() here?

Done. I also fixed some other path concatenations and pushed them in vNext.

@nulltoken
Copy link
Member

I'm uncomfortable with TreeChanges needing to consistently use Native for looking up paths - lot of room for error. I've started a local spike to switch the inner dictionary key to FilePath, which I hope will handle that more automagically... will finish tomorrow.

Ok :)

dahlbyk pushed a commit to dahlbyk/libgit2sharp that referenced this pull request Jun 12, 2012
@nulltoken @dahlbyk
Make TreeChanges and TreeEntryChanges expose native paths
508ba3e 
Fix libgit2#171
@dahlbyk
Copy link
Member Author

dahlbyk commented Jun 14, 2012

I don't remember if GH notifies when a new commit is pushed, but my rebound is here:
https://github.com/dahlbyk/libgit2sharp/commits/fix/treechanges-paths

@nulltoken nulltoken closed this in 824a1c1 Jun 14, 2012
@nulltoken
Copy link
Member

@dahlbyk Thanks for the review! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nulltoken @dahlbyk