Skip to content

Added unit test to demonstrate parsing bug #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

haacked
Copy link
Contributor

@haacked haacked commented Jul 3, 2012

Added a unit test to demonstrate a commit parsing bug that still exists.

LibGit2Sharp.LibGit2SharpException : An error was raised by libgit2.
Class = Odb (-1).
Failed to parse commit 54a169f6bcf7afdb4bbcd9517944b933422b9a92 -
cannot parse commit time...

Added a unit test to demonstrate a commit parsing bug that still exists.

LibGit2Sharp.LibGit2SharpException : An error was raised by libgit2.
Class = Odb (-1).
Failed to parse commit 54a169f6bcf7afdb4bbcd9517944b933422b9a92 -
cannot parse commit time...
@mfecteau
Copy link

Any idea when this will be released?

@nulltoken
Copy link
Member

The fix has been merged in libgit2 on July, 12th.

LibGit2Sharp vNext branch will be updated with a new version of libgit2 before July, 22nd.

@nulltoken
Copy link
Member

Thanks for the report. Fixed in vNext.

@nulltoken nulltoken closed this Jul 23, 2012
@mfecteau
Copy link

That didn't fix the issue. I have responded to the last email I received and have attached TheLog.txt to that email.

@nulltoken
Copy link
Member

@mfecteau I'm sorry, I'm not sure I understand what TheLog.txt refers to. Could you please give us more context?

That didn't fix the issue.

@haacked should this issue be reopened?

@mfecteau
Copy link

I was told, to follow an ongoing issue I had with the program shutting down every time it opens to go here. I was also told a fix for this issue would be released July 22. In any case I downloaded the latest from the web a couple of days ago and the issue remains. The program opens for a few seconds (up to 30 or so) and whether a click on anything or not the program shuts down. The comment about sending TheLog.txt in a separate email was just FYI. I thought this discussion would have access to that email trail. I replied to a previous email trail at "[email protected]", that's where I sent TheLog.txt.

@uluhonolulu
Copy link
Contributor

@mfecteau LibGit2Sharp is not a program, it doesn't open, and cannot be shutting down. It also doesn't produce logs. Looks like you're talking about something different.

@nulltoken
Copy link
Member

@mfecteau Wow, thanks a lot for this very detailed information! This is the bug tracker for the LibGit2Sharp, one of the components that GitHub for Windows depends on.

I know that the team behind GHfW is pretty efficient. Now that the bug that was bothering you has been fixed in LibGit2Sharp, a new version of GHfW should be released soon or someone from the support will reach out to you in order to keep you updated.

@haacked
Copy link
Contributor Author

haacked commented Jul 31, 2012

@mfecteau Yeah, I'm not sure we've incorporated this bug fix in yet. But we'll get to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants