Skip to content

Cleanup #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2014
Merged

Cleanup #678

merged 3 commits into from
Apr 16, 2014

Conversation

nulltoken
Copy link
Member

  • Drop obsolete members
  • Fix some issues pinpointed by Code Analysis
  • Upgrade to .Net 4.0
  • Review

@nulltoken
Copy link
Member Author

Yeah! Travis seems happy...

@@ -36,6 +36,7 @@ internal struct GitMergeOpts
/// <summary>
/// The results of `git_merge_analysis` indicate the merge opportunities.
/// </summary>
[Flags]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed. I actually untabified the whole file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: the tab fixes were amended into the wrong commit. ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duh. Fixed. 😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@nulltoken
Copy link
Member Author

:shipit: ⁉️

@dahlbyk
Copy link
Member

dahlbyk commented Apr 16, 2014

Nitpick aside, 👍

@jamill
Copy link
Member

jamill commented Apr 16, 2014

👍

@dahlbyk
Copy link
Member

dahlbyk commented Apr 16, 2014

:shipit:

@nulltoken nulltoken merged commit 6ff7bf8 into vNext Apr 16, 2014
@nulltoken nulltoken deleted the ntk/obsolete branch April 16, 2014 17:33
@nulltoken nulltoken added this to the v0.18.0 milestone Apr 25, 2014
@nulltoken nulltoken mentioned this pull request Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants