Improve marshaling of git oid #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing a simple copy of the byte array is a lot faster than using Marshal.PtrToStructure.
| return IsInvalid ? null : (GitOid?)MarshalAsGitOid(handle); | ||
| } | ||
|
|
||
| private static GitOid MarshalAsGitOid(System.IntPtr data) |
There was a problem hiding this comment.
Could you please add a bool throwWhenNull = true parameter (à la IntPtrExtensions)?
There was a problem hiding this comment.
@nulltoken I don't see why that is needed, the code already returns null when the handle is invalid.
There was a problem hiding this comment.
Duh.... You're right! I overlooked that this was a private function (unlike MarshalAs<>()).
|
Thanks! ✨ ✨ ✨ ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a simple copy of the byte array is a lot faster than using
Marshal.PtrToStructure.