Introduced Reference.IsValidName(string) #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -340,9 +340,10 @@ public virtual IEnumerable<Reference> FromGlob(string pattern) | |||
| /// </para> | |||
| /// <param name="canonicalName">The name to be checked.</param> | |||
| /// <returns>true is the name is valid; false otherwise.</returns> | |||
| [Obsolete("This method will be removed in the next release. Please use Remote.IsValidName(string) instead.")] | |||
There was a problem hiding this comment.
Please use Reference.IsValidName(string) instead.
copy/paste typo? 😉
|
Ups 😞 I should be more careful next time. |
|
Hmmm. It looks like you've accidentally merged your Once this is done, could you please
|
|
I really appreciate you take the time to aid novices and encouraging them to participate. Thanks ✋ |
|
😊 Please ping me when this is rebased on the latest |
Deprecated ReferenceCollection.IsValidName(string) . Updated Test . Fixes libgit2#680 Fixed typo in [Obsolete] tag. Rebase into current vNext.
|
@nulltoken Is it now correct? 😰 |
It is! |
|
@someoneigna And another one is in! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated ReferenceCollection.IsValidName(string) .
Updated CanTellIfAReferenceIsValid Test .
Fixes #680