Added libgit2 features to Repository.Version #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <summary> | ||
| /// Returns the features with which libgit2 was compiled. | ||
| /// </summary> | ||
| public static string Capablities |
There was a problem hiding this comment.
Could you please move this in the Proxy type?
|
Nice job! Once you've 💀d with 🔥 the evil whitespace, could you please squash the fixup commits into the first one so we merge this? |
Introduced NativeMethods.Capabilities . Added CanCreateValidVersionString() test . Displaced NativeMethods CompiledFeatures to Proxy Remove irrelevant region on Proxy Make Proxy.get_compiled_features match get_libgit2_features . Add mising [Flags] tag on GitBuiltInFeatures . Remote trailling whitespace in Proxy Resolves libgit2#676
|
🎱 |
| { | ||
| string versionInfo = Repository.Version; | ||
|
|
||
| Assert.NotNull(versionInfo); |
There was a problem hiding this comment.
Too late for this pass, but I wonder if we should at least check versionInfo against a regex?
There was a problem hiding this comment.
@dahlbyk Could you log an up-for-grab issue with what you've got in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #676