Introduce Network.ListReferences(Remote, Credentials)

[someoneigna]

Network.ListReferences(Remote) was marked Obsolete and it's users have been updated to use the new Network.ListReferences(Remote, Credentials).

Fixes #647

[dahlbyk]

I think we would want to have a test like https://github.com/libgit2/libgit2sharp/blob/vNext/LibGit2Sharp.Tests/FetchFixture.cs#L50-L66 for the Credentials behavior, otherwise tests shouldn't need to specify credentials.

[nulltoken]

Would the compiler cringe if credentials was null by default?

[dahlbyk]

I'll copy over my comment:

Do we really want to Obsolete the current method or just have it delegate to the other overload with credentials: null?

I believe the compiler will warn that making credentials optional here would conflict with the existing method.

Though now that I think about it, we've historically not considered adding optional parameters to existing methods to be a breaking change, since the call pattern doesn't change (just need to recompile dependent apps). So maybe we don't need to keep the old method, just add the parameter to it?

[nulltoken]

👍

[someoneigna]

What about this one 😃 ?

    [SkippableFact]
    public void CanListRemoteReferencesWithCredentials()
    {
        InconclusiveIf(() => string.IsNullOrEmpty(Constants.PrivateRepoUrl),
            "Populate Constants.PrivateRepo* to run this test");

        string remoteName = "origin";

        string repoPath = InitNewRepository();

        using (var repo = new Repository(repoPath) )
        {
            Remote remote = repo.Network.Remotes.Add(remoteName, Constants.PrivateRepoUrl);

            var references = repo.Network.ListReferences(remote, Constants.PrivateRepoCredentials);

            foreach (var directReference in references)
            {
                Assert.NotNull(directReference);
            }
        }
    }

[nulltoken]

@someoneigna Could you please reduce the first line of the commit message so that it doesn't exceed 50 chars?

Maybe

Make Network.ListReferences() accept credentials

Fixes #647

[someoneigna]

Done 👍

[nulltoken]

Please drop this trailing whitespace

[nulltoken]

Once you've tamed those nasty whitespaces, could you please rebase this on top of the latest vNext?

[nulltoken]

This change looks unrelated to the scope of this PR. Could you please revert it?

[nulltoken]

Neat!!!! ✨ ✨ ✨