-
Notifications
You must be signed in to change notification settings - Fork 899
Ease deployment of LibGit2Sharp based web sites #597 #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4ecb691
Updating targets file to ensure that NativeBinaries are copied to the…
sitereactor 6e0e9fd
Correcting identation
sitereactor 8c8d3ee
Removing referenced Tools folder which is no longer used
sitereactor 291a5c6
Removing powershell scripts which are no longer used in the nuget pac…
sitereactor 1c737da
Using MSBuildThisFileDirectory to avoid hard ref to path
sitereactor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<PropertyGroup> | ||
<PipelineCollectFilesPhaseDependsOn> | ||
CollectLibGitNativeBinaries; | ||
$(PipelineCollectFilesPhaseDependsOn); | ||
</PipelineCollectFilesPhaseDependsOn> | ||
</PropertyGroup> | ||
</Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<Target Name="CopyLibGit2SharpBinaries" AfterTargets="ResolveAssemblyReferences"> | ||
<CreateItem Include="%(ReferencePath.FullPath)" Condition="$([System.String]::new('%(ReferencePath.Filename)').StartsWith('LibGit2Sharp'))"> | ||
<Output TaskParameter="Include" ItemName="_LibGit2SharpReference" /> | ||
</CreateItem> | ||
<ItemGroup> | ||
<_LibGitFiles Include="..\packages\LibGit2Sharp.0.17.0.0\lib\net40\NativeBinaries\**\*" Condition="'%(_LibGit2SharpReference.FullPath)' != ''" /> | ||
<Content Include="%(_LibGitFiles.Identity)" Condition="'$(OutDir)' == 'bin\'"> | ||
<Link>..\$(OutDir)NativeBinaries\%(RecursiveDir)%(Filename)%(Extension)</Link> | ||
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
</Content> | ||
<Content Include="%(_LibGitFiles.Identity)" Condition="'$(OutDir)' != 'bin\'"> | ||
<Link>NativeBinaries\%(RecursiveDir)%(Filename)%(Extension)</Link> | ||
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
</Content> | ||
</ItemGroup> | ||
</Target> | ||
<Target Name="CollectLibGitNativeBinaries"> | ||
<ItemGroup> | ||
<_LibGitFiles Include="bin\NativeBinaries\**\*" /> | ||
<FilesForPackagingFromProject Include="%(_LibGitFiles.Identity)"> | ||
<DestinationRelativePath>bin\NativeBinaries\%(RecursiveDir)%(Filename)%(Extension)</DestinationRelativePath> | ||
</FilesForPackagingFromProject> | ||
</ItemGroup> | ||
</Target> | ||
</Project> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we're now leveraging targets and props, do we still need the
Tools
folder and the*.ps1
files?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they should just be removed. Forgot to ask if its okay to just go ahead and delete all those powershell scripts from the repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💀 them with 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 done 😉