Introduce revert #706
Merged
Introduce revert #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /// <summary> | ||
| /// Maximum similarity sources to examine (overrides | ||
| /// 'merge.renameLimit' config (default 200) |
There was a problem hiding this comment.
Thanks! I updated this with a bit more detail (copied pretty closely from lg2's comments for these parameters).
|
OK - I added tests for reverting merge commits. |
| /// b6fbb2. | ||
| /// </para> | ||
| /// </summary> | ||
| public int Mainline { get; set; } |
There was a problem hiding this comment.
@nulltoken I added some more comments around this parameter. Do you feel this clarifies this parameter? I am open to any other suggestions / wordsmithing on this comment.
|
@nulltoken Have you had a chance to look at this some more? |
|
Yep! Please squash so that we can merge this! ❤️ |
|
💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon @ben's great initial work to introduce the ability to revert a commit
I followed the same pattern for the
Signatureparameter as is used forMerge. If we want to update this pattern in general, I say we do that as a separate commit for all affected API's