Try to get rid of SafeDispose() calls #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, we can't get rid of However, we can make it much simpler and makes its goal more obvious: Avoiding to have check if the handle is Along the way I've found some places that could be simplified into a plain |
| @@ -442,10 +442,8 @@ internal GitObject LookupInternal(ObjectId id, GitObjectType type, FilePath know | |||
|
|
|||
| GitObjectSafeHandle obj = null; | |||
|
@Therzok One one your previous comment (that I can't seem to find anymore), was hinting at simplifying the code in This is now done and the returned diff handle should be disposed (even on error) by the callers of |
|
I deleted it right after. I was sleepy and unsure of what I wrote. :D |
git_branch_delete() only frees the handle upon success.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SafeDispose()extension method takes care of ensuring the handle is valid before disposing it.Let's try and get rid of this by moving the checks in
SafeHandleBase.ReleaseHandle()