Restore old Credentials API as Obsolete #767
Conversation
|
For now, introduced an internal interface to represent having both |
dahlbyk
changed the title
|
Yeah, preferring to use |
| public static CredentialsHandler GetCredentialsHandler(this ICredentialsProvider provider) | ||
| { | ||
| if (provider == null) | ||
| return null; |
There was a problem hiding this comment.
Could you add some braces here and below please?
There was a problem hiding this comment.
Could you add some braces here and below please?
Fixed
|
@dahlbyk Verrrrry classy! Could you please rebase on top of vNext? |
Done |
|
@dahlbyk Thanks. Travis seems unhappy with the |
| { | ||
| var methodsMissingFromInterfaces = | ||
| from t in Assembly.GetAssembly(typeof(IRepository)).GetExportedTypes() | ||
| where !t.IsInterface | ||
| where t.GetInterfaces().Any(i => i.Namespace == typeof(IRepository).Namespace) | ||
| where t.GetInterfaces().Any(i => i.IsPublic && i.Namespace == typeof(IRepository).Namespace) |
There was a problem hiding this comment.
Travis seems unhappy with the
LibGit2SharpInterfacesCoverAllPublicMembers()meta test though.
Not sure how I didn't notice this before... ICredentialsProvider is our first non-public interface; no need to test it.
|
@dahlbyk As usual, a very clean job! 💖 |
To make #761 less of a breaking change.
TODO:
*Options.Credentialsproperties.Currently branched from the HEAD of that PR to make it easier to compare with the previous public API:
7765c12~...dahlbyk;ObsoleteCredentials