Release v0.19 #798
Release v0.19 #798
Conversation
|
Fix #791 as well |
nulltoken
force-pushed
the
ntk/release
branch
3 times, most recently
from
e8786d7 to
c0dc4e1
Compare
|
@dennisfrostlander Could you please try this out? It contains the libgit2/libgit2#2531 fix. |
| @@ -69,6 +69,11 @@ public enum FileStatus | |||
| RenamedInWorkDir = (1 << 11), /* GIT_STATUS_WT_RENAMED */ | |||
|
|
|||
| /// <summary> | |||
| /// The file is unreadable in the working directory. | |||
| /// </summary> | |||
| Unreadable = (1 << 11), /* GIT_STATUS_WT_UNREADABLE */ | |||
| /// <summary> | ||
| /// Entry is unreadable. | ||
| /// </summary> | ||
| Unreadable = 8, |
There was a problem hiding this comment.
Wrong value? It's the same as TypeChanged.
There was a problem hiding this comment.
🎱 Good catch! Thanks as well!
|
|
||
| Ensure.GitObjectIsNotNull(commit, "HEAD"); | ||
|
|
||
| return commit.Id; |
There was a problem hiding this comment.
Could this return commit and use the GitObjectoverload of Add()?
|
...Also made sure that we were throwing |
|
Fix #783 as well |
|
Without any further feedback, I'll get this merged in the following hours. |
| { | ||
| Commit commit = repository.Head.Tip; | ||
|
|
||
| Ensure.GitObjectIsNotNull(commit, "HEAD", m => new UnbornBranchException(m)); |
There was a problem hiding this comment.
Does the exceptionBuilder here really need to be explicit? Seems like that overload could be private, letting HEAD here be detected as with all other uses of the method.
|
FWIW, we've discovered a last blocker. Release will happen when libgit2/libgit2#2538 is merged. |
|
@nulltoken thanks for the update |
|
@dahlbyk Thanks for the review. That led to a much simpler code. Does this fit you? |
👍 |
We cannot make correct assumptions regarding the fact that the environment that host the test runner: - Contains a global git config file - Grants the test runner process with enough rights to write to this file - That this file already contains an expected entry Given those constraints, those tests are removed.
|
FWIW, I've also added 96d270f. Travis has made some changes regarding the global config file. That led those tests to fail. That led me to think that they shouldn't be part of the suite. |
|
The NuGet package has just been published 😄 |
Among others, fix #701 and #794