feat(transports/webrtc-websys): Browser to Browser WebRTC #5978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sport to work with a relay server. Implements a protobuf stream wrapper to write Signaling messages over the relay. Exposes the rtc peer connection on a Connection.
|
This pull request has merge conflicts. Could you please resolve them @elijahhampton? 🙏 |
…unctions to libp2p_webrtc_utils. Adds tracking for connection states through callbacks for SignalingProtocol. Creates directory for circuit-relay-v2 implementation.
dariusc93
reviewed
Apr 10, 2025
transports/circuit-relay-v2/build.rs
Outdated
Comment on lines
1
to
4
| fn main() { | ||
| prost_build::compile_protos(&["src/proto/message.proto"], &["src/proto"]) | ||
| .unwrap(); | ||
| } |
There was a problem hiding this comment.
Just a quick FYI, we should not use prost but instead use quick-protobuf :). See #3024
There was a problem hiding this comment.
Got it. Thanks for catching that.
…y with browser transport, not feature gated. Addition of circuit relay v2 package to libp2p exports. Addition of circuit relay v2 protobuf structures.
4 tasks
|
Update to the PR coming soon |
…o behaviour and handler and modifies relay example to listen over /ws
…andler. Updates config to include variables for max connection checks and connection check delays. Improved logging and error handling
elijahhampton
changed the title
elijahhampton
changed the title
|
@dariusc93 @elenaf9 Can I get an initial review on this? |
elijahhampton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4389. WebRTC implementation for browser to browser. This PR is currently in draft. More functionality will be added in the coming days. The PR is open for feedback and suggestions as the implementation is completed.
Notes & open questions
Change checklist