feat: support SNI multiaddrs in WebSocket transport #6041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rose2221
changed the title
|
Hi @elenaf9 , just following up on this PR — let me know if there’s any further feedback or if it looks good to you. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for WebSocket dialing with multiaddrs of the form:
This enables
rust-libp2pnodes to connect to WSS peers using SNI-based addressing, as introduced in the libp2p specs for autotls support.Motivation
Services like autotls allow nodes to obtain certificates matching their Peer ID. This PR enables
rust-libp2pto dial these nodes using canonical SNI multiaddrs (e.g./tls/sni/<peerid>.libp2p.direct/ws), which were previously unsupported.Related
Fixes #5814
Spec: libp2p websocket spec
Change checklist