refactor(kad): Add Key
to InboundRequest::{AddProvider, PutRecord}
.
#6049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
Key
toInboundRequest::AddProvider
andInboundRequest::PutRecord
to provide the record key when it is inserted into theRecordStore
.Resolves #6048.
Notes & open questions
While one could just enable filtering, check the record for the key and then insert it into the store, I do feel this would provide information without requiring one to enable filtering and be responsible for inserting into the store.
Question:
Option<Key>
so when if filtering is enabled, the field would returnNone
and with it being . disabled, it would returnSome(_)
?Change checklist