Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Add integration test utils, first LSPS2 integration test #118

Merged
merged 4 commits into from
May 14, 2024

Conversation

tnull
Copy link
Collaborator

@tnull tnull commented Mar 2, 2024

Here, we add some integration test utils and add an initial integration test that covers the LSPS2 invoice generation flow up to creating a new invoice. In the future we'll extend that to create a full-cycle test.

However, as this is already quite a bit of code, extending it to a full-cycle test will happen in a follow-up PR.

@tnull tnull force-pushed the 2024-02-add-test-utils branch 11 times, most recently from ccc3c21 to 68fb676 Compare March 7, 2024 14:51
@tnull tnull force-pushed the 2024-02-add-test-utils branch from 68fb676 to dffa067 Compare March 26, 2024 07:27
@tnull tnull force-pushed the 2024-02-add-test-utils branch 2 times, most recently from 628f4a9 to ff8c342 Compare May 13, 2024 16:57
tnull added 2 commits May 13, 2024 19:00
.. we test the invoice generation flow up until creating a JIT invoice.
@tnull tnull force-pushed the 2024-02-add-test-utils branch from ff8c342 to 10e4b17 Compare May 13, 2024 17:00
@tnull
Copy link
Collaborator Author

tnull commented May 13, 2024

Rebased for LDK v0.0.123.

@johncantrell97 Would be great to get some intial review on this.

@johncantrell97
Copy link
Contributor

This looks fine to me, I don't really have any comments to add. It seems like most of the stuff in common is directly from ldk, right?

Nice that you're able to use the library in this modular way to pipe the request/responses in and out without any changes.

@tnull
Copy link
Collaborator Author

tnull commented May 14, 2024

This looks fine to me, I don't really have any comments to add. It seems like most of the stuff in common is directly from ldk, right?

Yes, mostly stolen from the BackgroundProcessor tests, but deleted a lot of unnecessary code and modified some other parts.

Nice that you're able to use the library in this modular way to pipe the request/responses in and out without any changes.

Yep!

@tnull
Copy link
Collaborator Author

tnull commented May 14, 2024

Fixed MSRV CI, going ahead and merge this for now. We'll interate on the test (utils) in the future anyways.

@tnull tnull merged commit 30e80d4 into lightningdevkit:main May 14, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants