This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Fix more potential deadlock scenarios #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. as tiny helpers like this just tend to obfuscate what's going on.
.. as tiny helpers like this just tend to obfuscate what's going on.
.. as tiny helpers like this just tend to obfuscate what's going on.
.. which avoids a potential deadlock
.. which avoids a potential deadlock
.. which avoids a potential deadlock
.. which avoids a potential deadlock
tnull
force-pushed
the
2024-03-fix-deadlock
branch
from
f9d8dd5 to
6b7b875
Compare
wvanlint
approved these changes
Mar 25, 2024
Yeah, we could eventually consider a larger refactor to some structure that would prohibit us from ever holding the lock while enqueueing. This might be a good idea, but if we do that however, I'd like to share it across LSPS1/2 at least, which might require some more prefactors to make them more uniform. Landing this for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we previously already fixed some potential deadlock issues, some more remained in the LSPS1/LSPS2 implementations due to holding the peer locks when enqueuing request/response messages as the latter would trigger
PeerManager::process_eventscould result in circular waits. Here, we make sure to always drop the locks first, before enqueuing request/response messages.