This repository was archived by the owner on Jan 6, 2025. It is now read-only.
LSPS1: Fix and test serialization #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we'd decode/encode `payload` with `String`'s default encoding, which prepends the lenght. However, according to BOLT8/LSPS0 describe the payload as: "A variable-length message payload (the remainder of the message).", i.e., without any prepended lenght. Here, we fix this de/ser bug by encoding and decoding the payload using LDK's `WithoutLength` helper.
Previously, during a cleanup, we accidentally also renamed the actual `BuyResponse` field, not only our internal variables. Here, we fix this regression to reestablish compliance with the spec.
.. to account for the spec changes in BitcoinAndLightningLayerSpecs/lsp#88
.. to account for the spec changes in BitcoinAndLightningLayerSpecs/lsp#88 In particular we also introduce the `CLIENT_REJECTED` error as part of LSPS0, but currently don't use it (yet).
.. not super descriptive, but more in line with `ChannelInfo`
tnull
force-pushed
the
2024-03-lsps1-client
branch
from
1ae3016 to
812ad1d
Compare
johncantrell97
approved these changes
Apr 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #124.
Fixes #122.
Fixes #123.
Fixes #65.