Open
Description
Shouldn't hold up this PR, but is there any reason why we don't simply add a
TxAbort
variant toInteractiveTxMessageSend
? Then we wouldn't need eitherInteractiveTxMessageSendResult
orHandleTxCompleteResult
, IIUC, which would remove two layers of structs.Otherwise, we go through the following conversions just to end up with a
MessageSendEvent
:
Result<InteractiveTxMessageSend, AbortReason>
InteractiveTxMessageSendResult(Result<InteractiveTxMessageSend, msgs::TxAbort>)
MessageSendEvent
The
Result
s don't seem to buy us anything more than the extra variant would as we aren't doing anything special for theErr
case. Then it would simply be:
InteractiveTxMessageSend
MessageSendEvent
And AFAICT,
InteractiveTxConstructor
has thechannel_id
, so there's no need to grab it from theChannelContext
. Or will it change in some case?
Originally posted by @jkczyz in #3137 (comment)