Enforces sig_rec length in message_signing #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
- Coverage 90.76% 90.76% -0.01%
==========================================
Files 60 60
Lines 30909 30911 +2
==========================================
- Hits 28056 28055 -1
- Misses 2853 2856 +3
Continue to review full report at Codecov.
|
sr-gi
force-pushed
the
enforce_signature_length
branch
from
e060304 to
8a1c538
Compare
TheBlueMatt
approved these changes
Jul 20, 2021
ariard
reviewed
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforces signature length to be 65-bytes long in
message_signing::sig_rec(64 bytes for the compact signature + 1 byte for the recovery id).close #1005