Add a further test of HTLC failure after a claim occurrs.

[TheBlueMatt]

This adds a further test of 7e78fa6
which I had lying around in my TODO list for a while.

[codecov]

Codecov Report

Merging #1058 (61bf4d2) into main (8d886ee) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   90.36%   90.59%   +0.22%     
==========================================
  Files          69       69              
  Lines       36794    38849    +2055     
==========================================
+ Hits        33249    35195    +1946     
- Misses       3545     3654     +109     

Impacted Files	Coverage Δ
lightning/src/ln/chanmon_update_fail_tests.rs	97.68% <100.00%> (+0.03%)	⬆️
lightning/src/ln/functional_tests.rs	97.58% <0.00%> (+0.21%)	⬆️
lightning/src/chain/onchaintx.rs	95.03% <0.00%> (+0.28%)	⬆️
lightning/src/chain/channelmonitor.rs	91.50% <0.00%> (+0.38%)	⬆️
lightning/src/chain/package.rs	92.89% <0.00%> (+0.61%)	⬆️
lightning/src/ln/functional_test_utils.rs	96.38% <0.00%> (+1.24%)	⬆️
lightning/src/ln/channelmanager.rs	86.65% <0.00%> (+2.97%)	⬆️
lightning-invoice/src/utils.rs	86.82% <0.00%> (+3.33%)	⬆️
lightning/src/util/events.rs	41.00% <0.00%> (+6.34%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d886ee...61bf4d2. Read the comment docs.

[valentinewallace]

Test fails as expected on commits prior to 7e78fa6

[TheBlueMatt]

Trivially rebased.

[TheBlueMatt]

Oops, test needed updating for the ChannelClosed event, did so.

[jkczyz]

When I rebase on main, the newly added test fails.

thread 'ln::chanmon_update_fail_tests::test_fail_htlc_on_broadcast_after_claim' panicked at 'assertion failed: events.len() > 1', lightning/src/ln/chanmon_update_fail_tests.rs:2100:5

[codecov-commenter]

Codecov Report

Merging #1058 (61bf4d2) into main (f6fa8e9) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head 61bf4d2 differs from pull request most recent head 305a0d9. Consider uploading reports for the commit 305a0d9 to get more accurate results

@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
- Coverage   90.80%   90.59%   -0.22%     
==========================================
  Files          73       69       -4     
  Lines       41209    38849    -2360     
  Branches    41209        0   -41209     
==========================================
- Hits        37420    35195    -2225     
+ Misses       3789     3654     -135     

Impacted Files	Coverage Δ
lightning/src/ln/chanmon_update_fail_tests.rs	97.68% <100.00%> (-0.04%)	⬇️
lightning-invoice/src/utils.rs	86.82% <0.00%> (-9.87%)	⬇️
lightning/src/chain/chainmonitor.rs	90.87% <0.00%> (-6.77%)	⬇️
lightning/src/util/errors.rs	67.30% <0.00%> (-3.07%)	⬇️
lightning/src/ln/peer_handler.rs	49.77% <0.00%> (-2.84%)	⬇️
lightning/src/routing/scoring.rs	91.63% <0.00%> (-2.67%)	⬇️
lightning/src/util/logger.rs	83.14% <0.00%> (-2.28%)	⬇️
lightning/src/util/ser_macros.rs	86.89% <0.00%> (-2.25%)	⬇️
lightning-block-sync/src/init.rs	93.56% <0.00%> (-2.25%)	⬇️
lightning/src/util/config.rs	45.65% <0.00%> (-1.16%)	⬇️
... and 42 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6fa8e9...305a0d9. Read the comment docs.

[TheBlueMatt]

Rebased, had to very slightly tweak the end to handle the new PaymentPathSuccessful event.