-
Notifications
You must be signed in to change notification settings - Fork 411
Enable Dependabot #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Dependabot #1243
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1243 +/- ##
==========================================
- Coverage 90.42% 90.41% -0.02%
==========================================
Files 70 70
Lines 38087 38087
==========================================
- Hits 34441 34436 -5
- Misses 3646 3651 +5
Continue to review full report at Codecov.
|
1822fb1
to
083a9d5
Compare
I am new to Rust. Is this a blocker? |
Its certainly very annoying, but I wouldn't call it a blocker. I assume if dependabot opens a PR and CI fails due to MSRV we can just close the PR and dependabot will shut up? |
Yes and also we can tell dependabot to ignore that version and so going forward it will not open a PR for either that minor or major version. |
LGTM, just seeking clarification on #1243 (comment) |
Signed-off-by: naveen <[email protected]>
083a9d5
to
126771d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. worst case its broken and nothing happens, best case we get automated dep-bump prs, most of which will be useless cause we have to adapt to API changes, but hey, notifications good, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like that was auto-enabled when we added the file to the main branch. |
That is surprising! |
With the rise in supply chain attacks, it helps to get the dependency updates.
Even if the project decides not to update the dependency it helps to be informed.
The dependabot settings have to be enabled in the security settings of the repository.