Skip to content

Enable Dependabot #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

naveensrinivasan
Copy link
Contributor

With the rise in supply chain attacks, it helps to get the dependency updates.

Even if the project decides not to update the dependency it helps to be informed.

The dependabot settings have to be enabled in the security settings of the repository.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #1243 (083a9d5) into main (34cdca9) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 083a9d5 differs from pull request most recent head 126771d. Consider uploading reports for the commit 126771d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   90.42%   90.41%   -0.02%     
==========================================
  Files          70       70              
  Lines       38087    38087              
==========================================
- Hits        34441    34436       -5     
- Misses       3646     3651       +5     
Impacted Files Coverage Δ
lightning/src/ln/functional_tests.rs 97.28% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34cdca9...126771d. Read the comment docs.

@Kixunil
Copy link
Contributor

Kixunil commented Jan 17, 2022

@naveensrinivasan
Copy link
Contributor Author

FIY dependabot seems to have no special handling of MSRV

I am new to Rust. Is this a blocker?

@TheBlueMatt
Copy link
Collaborator

Its certainly very annoying, but I wouldn't call it a blocker. I assume if dependabot opens a PR and CI fails due to MSRV we can just close the PR and dependabot will shut up?

@naveensrinivasan
Copy link
Contributor Author

Yes and also we can tell dependabot to ignore that version and so going forward it will not open a PR for either that minor or major version.

@TheBlueMatt
Copy link
Collaborator

LGTM, just seeking clarification on #1243 (comment)

@naveensrinivasan naveensrinivasan force-pushed the naveensrinivasan/dependabot branch from 083a9d5 to 126771d Compare January 18, 2022 19:39
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. worst case its broken and nothing happens, best case we get automated dep-bump prs, most of which will be useless cause we have to adapt to API changes, but hey, notifications good, I guess.

@naveensrinivasan
Copy link
Contributor Author

LGTM. worst case its broken and nothing happens, best case we get automated dep-bump prs, most of which will be useless cause we have to adapt to API changes, but hey, notifications good, I guess.

This will work only when the settings are turned on the security settings like this.

image

Copy link
Contributor

@arik-so arik-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arik-so arik-so merged commit 10204f7 into lightningdevkit:main Jan 18, 2022
@naveensrinivasan naveensrinivasan deleted the naveensrinivasan/dependabot branch January 18, 2022 22:05
@TheBlueMatt
Copy link
Collaborator

Looks like that was auto-enabled when we added the file to the main branch.

@naveensrinivasan
Copy link
Contributor Author

Looks like that was auto-enabled when we added the file to the main branch.

That is surprising!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants