[0.0.105] (Bindings Only) Concretize LockableScore as MultiThreadedLockableScore #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2022-02-bindings-105
branch
from
57c1d7e to
675d4ef
Compare
We don't really care about more than this in bindings - calling into a custom `Score` is likely too slow to be practical anyway, so this is also a performance improvement. Works around rust-lang/rust#90448
...as the bindings generation does not currently have the ability to map a reference to a `NodeId` inside a tuple.
TheBlueMatt
force-pushed
the
2022-02-bindings-105
branch
from
675d4ef to
fec5dcb
Compare
.. as the current C bindings generator isn't capable of handling type aliases in generics in type alias definition currently.
TheBlueMatt
force-pushed
the
2022-02-bindings-105
branch
from
fec5dcb to
2d210c0
Compare
jkczyz
approved these changes
Mar 1, 2022
valentinewallace
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really care about more than this in bindings - calling
into a custom
Scoreis likely too slow to be practical anyway,so this is also a performance improvement.
Works around rust-lang/rust#90448
This is a forward port of the same commit as applied to 0.0.104 and 0.0.103, now on a new branch -
0.0.105-bindings, which I'll update to 0.0.105 before we land this (after 105 is tagged).