Refactor funding_created to wrapper error handling function #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariard
changed the title
TheBlueMatt
approved these changes
Sep 6, 2018
There was a problem hiding this comment.
Squashed + merged (with the TODO removed).
I dont really care about one-big-PR-vs-many-smaller-PRs, whatever's easier for you, but if its one huge chunk would have to make sure we can iterate fast and get it merged so we avoid tons of rebase issues.
I would prefer, however, that there aren't intermediate commits that don't build/pass tests if only as it can make git bisect harder.
| (chan.remove(), funding_msg, monitor_update) | ||
| }, | ||
| Err(e) => { | ||
| //TODO: Possibly remove the channel depending on e.action |
There was a problem hiding this comment.
This TODO can go away.
TheBlueMatt
added a commit
that referenced
this pull request
Sep 6, 2018
Refactor handle_funding_created to wrapper error handling function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And filling the error actions along the way (though it's under #153 case)
(side-note: do you prefer one big PR for handle_MSG refactor or split in many as it is?)