Skip to content

Clarify description of get_node_secret() method #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

danielgranhao
Copy link
Contributor

I was confused by the original description, so I'm proposing a small change.
Probably for most, it was obvious that the secret key is not the node_id itself, but when I read this initially, I even thought that maybe the node_id/public key was being held in a SecretKey struct.

@codecov-commenter
Copy link

Codecov Report

Merging #1556 (526d381) into main (16115cd) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1556      +/-   ##
==========================================
+ Coverage   90.94%   90.97%   +0.02%     
==========================================
  Files          80       80              
  Lines       43610    43831     +221     
  Branches    43610    43831     +221     
==========================================
+ Hits        39661    39874     +213     
- Misses       3949     3957       +8     
Impacted Files Coverage Δ
lightning/src/chain/keysinterface.rs 93.59% <ø> (ø)
lightning/src/chain/onchaintx.rs 93.98% <0.00%> (-0.93%) ⬇️
lightning/src/ln/functional_tests.rs 96.89% <0.00%> (-0.05%) ⬇️
lightning-invoice/src/lib.rs 87.39% <0.00%> (ø)
lightning/src/ln/functional_test_utils.rs 95.23% <0.00%> (ø)
lightning/src/routing/router.rs 92.57% <0.00%> (+<0.01%) ⬆️
lightning/src/ln/channelmanager.rs 84.39% <0.00%> (+<0.01%) ⬆️
lightning/src/ln/payment_tests.rs 99.25% <0.00%> (+<0.01%) ⬆️
lightning/src/ln/channel.rs 88.72% <0.00%> (+0.13%) ⬆️
lightning/src/ln/onion_route_tests.rs 97.68% <0.00%> (+0.16%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16115cd...526d381. Read the comment docs.

@valentinewallace valentinewallace merged commit 10071b5 into lightningdevkit:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants