Further minor misc changes from reconnect work #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both get_update_fail_htlc and get_update_fulfill_htlc should never be called before any HTLC could have been accepted (ie pre-ChannelFunded) nor should they ever be called post-ShutdownComplete as the Channel object should be destroyed at that point. Previously get_update_fulfill_htlc would panic, but get_update_fail_htlc would return an Err. For now make them both panic but we can revisit this if we want to have fewer panics in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly I discovered I want to overhaul pending-HTLC tracking before I merge the reconnect stuff, though I've gotten most of that hashed out. Hopefully the pending-HTLC overhaul will also reduce panic!()s in Channel which assert ChannelManager sanity (except for the state-precondition-check ones).