Stop building with lockorder debugging in benchmarks #1725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo bench` sets `#[cfg(test)]` so our current checks for enabling our lockorder debugging end up matching when we're trying to build performance benchmarks. This adds explicit checks to our debug_lockorder logic to filter out `feature = "_bench_unstable"` builds.
Codecov ReportBase: 90.77% // Head: 90.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
==========================================
- Coverage 90.77% 90.74% -0.04%
==========================================
Files 86 86
Lines 46631 46631
Branches 46631 46631
==========================================
- Hits 42331 42314 -17
- Misses 4300 4317 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
valentinewallace
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo benchsets#[cfg(test)]so our current checks for enabling our lockorder debugging end up matching when we're trying to build performance benchmarks.This adds explicit checks to our debug_lockorder logic to filter out
feature = "_bench_unstable"builds.