[0.0.111-bindings] Don't make references to std in lightning-invoice in bindings
#1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.75% // Head: 90.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 0.0.111-bindings #1741 +/- ##
====================================================
+ Coverage 90.75% 90.78% +0.03%
====================================================
Files 86 86
Lines 46530 46530
Branches 46530 46530
====================================================
+ Hits 42228 42243 +15
+ Misses 4302 4287 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tnull
reviewed
Sep 26, 2022
There was a problem hiding this comment.
Seems the TestScorer also needs updating:
rust-lightning/lightning-invoice/src/payment.rs
Line 1916 in 969574c
LGTM other than that.
As we support `no-std` for `lightning-invoice` builds, we should support them in `c_bindings` as well, which we add a test for in CI here.
TheBlueMatt
force-pushed
the
2022-09-invoice-bindings-nostd-111
branch
from
6d3be34 to
a126a4e
Compare
valentinewallace
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we support
no-stdforlightning-invoicebuilds, we should support them inc_bindingsas well, which we add a test for in CI here.Ugh, yet another one...hopefully the last...