Add KeysInterface::get_node_id method
#1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.71% // Head: 90.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1779 +/- ##
==========================================
- Coverage 90.71% 90.68% -0.03%
==========================================
Files 87 87
Lines 47353 47374 +21
Branches 47353 47374 +21
==========================================
+ Hits 42958 42963 +5
- Misses 4395 4411 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Ugh sorry for the dup comments, github really doesn't handle internet with 5second+ latency well... |
valentinewallace
force-pushed
the
2022-10-node-pk-keysinterface
branch
from
2386a9f to
71a8051
Compare
Useful since we're working on getting rid of KeysInterface::get_node_secret to complete support for remote signing. Will be used in upcoming work to check whether an outbound onion message blinded path has our node id as the introduction node id
valentinewallace
force-pushed
the
2022-10-node-pk-keysinterface
branch
from
71a8051 to
17c0fc8
Compare
valentinewallace
changed the title
KeysInterface::get_node_id method
TheBlueMatt
previously approved these changes
Oct 21, 2022
ariard
reviewed
Oct 21, 2022
dunxen
previously approved these changes
Oct 24, 2022
valentinewallace
force-pushed
the
2022-10-node-pk-keysinterface
branch
from
19f662a to
7082d6c
Compare
dunxen
approved these changes
Oct 24, 2022
TheBlueMatt
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful since we're working on getting rid of
KeysInterface::get_node_secretto complete support for remote signing.Will be used in upcoming work to check whether an outbound onion message blinded path has our node id as the introduction node id