Ignore HTLC txn we dont know how to claim instead of unwrap()ing and Do not fail-backwards LocalAnnounced HTLCs upon force-close. #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash introduced in 3e149b1 and introduces a test which will tickle the bug.
This is completely unsafe as we have provided the remote side with a commitment_signed which they can broadcast, including the HTLC transaction, and then could claim it on-chain after we've failed it backwards!
TheBlueMatt
force-pushed
the
2018-09-htlc-tx-unwrap-fix
branch
from
30176d4 to
aa17def
Compare
TheBlueMatt
changed the title
|
Merging to keep things moving, obviously happy to have postumous review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash introduced in 3e149b1
and introduces a test which will tickle the bug.
Also fixes a second bug with force-closure that could lose money, as well as adds tests for it in ChannelManager.
Finally, make full_stack_target's sample tickle the original crash as well as cover the code that generated the second failure.