Drop old serialization framework #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2018-09-ser-rework-2
branch
3 times, most recently
from
e55fa69 to
2c4b1aa
Compare
Should resolve any performance issues with Vec<u8> serialization.
Fixes a bug introduced in 3e89106 where messages were being encoded with their size instead of their type. Also utilizes the new size_hinting in peer_handler
This removes a bunch of potentially new error handling in writers and the checks were kinda useless anyway - in normal operation we unwrap()ed anyway, and we're gonna want to use the serializtion framework for ChannelMonitor/ChannelManager serialization, which may generate things larger than 64KB anyway.
This lets us add some untyped default functions to the trait
TheBlueMatt
force-pushed
the
2018-09-ser-rework-2
branch
from
2c4b1aa to
c91f72c
Compare
|
Concept ACK, far less code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #185 and finally drops our old serialization framework, as well as cleans up a few other bits that weren't covered in #185.