Drop serde dependency from lightning-block-sync
#2116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2116 +/- ##
==========================================
+ Coverage 91.32% 91.47% +0.14%
==========================================
Files 101 101
Lines 48791 49513 +722
Branches 48791 49513 +722
==========================================
+ Hits 44558 45290 +732
+ Misses 4233 4223 -10
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
tnull
previously approved these changes
Mar 20, 2023
dunxen
previously approved these changes
Mar 20, 2023
`serde` doesn't bother with MSRVs, so its expected to break frequently. Yesterday, the `derive` feature had its MSRV broken in a patch version without care. Luckily its trivial for us to remove the `serde` dependency in `lightning-block-sync`, using only `serde_json` for the JSON deserialization part. It even ends up net-negative on LoC.
TheBlueMatt
force-pushed
the
2023-03-serde-sucks
branch
from
243b9fd to
b701a6c
Compare
dunxen
approved these changes
Mar 20, 2023
tnull
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serdedoesn't bother with MSRVs, so its expected to break frequently. Yesterday, thederivefeature had its MSRV broken in a patch version without care.Luckily its trivial for us to remove the
serdedependency inlightning-block-sync, using onlyserde_jsonfor the JSON deserialization part. It even ends up net-negative on LoC.