Make lightning-transaction-sync compat notice a bit more explicit

[tnull]

Resolves #2254.

As lightning-transaction-sync was introduced with 0.0.114 and depended on prior changes in the same release cycle we deemed it reasonable to omit the implicitly limited backwards compatibility.

It however turns out this might be confusing to users copy/pasting the codebase. Here we therefore spell out the implicit dependency on 0.0.114 and above.

[TheBlueMatt]

The way I read this if you create a channel on 113 and then upgrade to 114 this crate won't work, but I didn't think that was the requirement, rather you can as long as it was created >= 113 and you're using this crate against LDK 114+ objects themselves.

[tnull]

Mh, yeah, maybe. Tbh, I'm not sure if this 'clarification' is actually needed or may lead to even more confusion.
Maybe our initial assumption that nobody would use the crate against objects lower than 114 is still sufficient afterall, even though there was one recent outlier?

[TheBlueMatt]

Yea, I mean AFAIU you explicitly cannot without forking it, since it requires the traits in 114 as its dependency. Another way to phrase it is just "this crate only works with LDK version 114 and above using channels which were created on LDK version 113 and above"?

[tnull]

Alright, now amended the commit:

diff --git a/lightning-transaction-sync/src/lib.rs b/lightning-transaction-sync/src/lib.rs
index 3955bc68..ca3ce3f8 100644
--- a/lightning-transaction-sync/src/lib.rs
+++ b/lightning-transaction-sync/src/lib.rs
@@ -14,6 +14,6 @@
 //! ## Version Compatibility
 //!
-//! Currently this crate is compatible with nodes that were created with LDK version 0.0.114 and
-//! above and channels that were created with LDK version 0.0.113 and above.
+//! Currently this crate is compatible with LDK version 0.0.114 and above using channels which were
+//! created on LDK version 0.0.113 and above.
 //!
 //! ## Usage Example:

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (e94647c) 91.50% compared to head (110956f) 91.48%.

❗ Current head 110956f differs from pull request most recent head ff865eb. Consider uploading reports for the commit ff865eb to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2270      +/-   ##
==========================================
- Coverage   91.50%   91.48%   -0.02%     
==========================================
  Files         104      104              
  Lines       52087    52087              
  Branches    52087    52087              
==========================================
- Hits        47660    47652       -8     
- Misses       4427     4435       +8     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.