Skip to content

Check too many tx outputs upfront when verifying funding tx #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2023

Conversation

benthecarman
Copy link
Contributor

Before you would need to iterate through all 2^16 outputs before throwing this error, thus wasting a lot of time. Moved so this check is just done upfront.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.54 ⚠️

Comparison is base (818dbdf) 91.50% compared to head (fcd1127) 90.96%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2278      +/-   ##
==========================================
- Coverage   91.50%   90.96%   -0.54%     
==========================================
  Files         104      104              
  Lines       52087    52656     +569     
  Branches    52087    52656     +569     
==========================================
+ Hits        47660    47900     +240     
- Misses       4427     4756     +329     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 87.23% <33.33%> (+<0.01%) ⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wpaulino wpaulino merged commit 1279c68 into lightningdevkit:main May 9, 2023
@benthecarman benthecarman deleted the faster-u16-check branch May 9, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants