Skip to content

Remove spurious docs which imply you cannot retry a failed payment #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

TheBlueMatt
Copy link
Collaborator

If a payment (fully) fails, users are free to retry it, its only once a payment succeeds that a user must never retry it.

If a payment (fully) fails, users are free to retry it, its only
once a payment succeeds that a user must never retry it.
wpaulino
wpaulino previously approved these changes Jun 6, 2023
Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a double comma we could fix on lines 110-111.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 97.49% and project coverage change: +0.11 🎉

Comparison is base (ede06d8) 90.33% compared to head (60ce627) 90.44%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2340      +/-   ##
==========================================
+ Coverage   90.33%   90.44%   +0.11%     
==========================================
  Files         104      104              
  Lines       53392    54046     +654     
  Branches    53392    54046     +654     
==========================================
+ Hits        48229    48881     +652     
- Misses       5163     5165       +2     
Impacted Files Coverage Δ
lightning-invoice/src/payment.rs 88.66% <ø> (ø)
lightning/src/ln/peer_handler.rs 61.47% <89.70%> (+1.15%) ⬆️
lightning-background-processor/src/lib.rs 82.58% <100.00%> (+0.12%) ⬆️
lightning-net-tokio/src/lib.rs 76.94% <100.00%> (+0.20%) ⬆️
lightning/src/ln/chanmon_update_fail_tests.rs 98.63% <100.00%> (+0.02%) ⬆️
lightning/src/ln/channelmanager.rs 86.32% <100.00%> (+0.02%) ⬆️
lightning/src/ln/functional_test_utils.rs 88.03% <100.00%> (+0.12%) ⬆️
lightning/src/ln/functional_tests.rs 98.25% <100.00%> (+<0.01%) ⬆️
lightning/src/ln/msgs.rs 84.58% <100.00%> (+0.01%) ⬆️
lightning/src/ln/payment_tests.rs 97.58% <100.00%> (+0.01%) ⬆️
... and 7 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants