Several fuzz-found bugfixes. #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2018-11-fuzz-crash-redux
branch
from
1e43c55 to
8cbb3f7
Compare
366e796 fixed the same crash for Errs that come up during handshake, but was incomplete and should have just dropped the node_id being different based on inbound/outbound. This patch does so and actually fixes the issue. Found by fuzzer.
This fixes a bug in 78232f2 found by fuzzer - if the channel isn't yet fully established we will call get_channel_update(), get an Err result, and then unwrap() it. If this actually happens it means someone on the network is making up short_channel_ids and trying to route over them, but that shouldn't result in us crashing
TheBlueMatt
force-pushed
the
2018-11-fuzz-crash-redux
branch
from
8cbb3f7 to
3a066cc
Compare
TheBlueMatt
changed the title
|
Added another bugfix commit found by fuzzer and one to make fuzzing a bit more performant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
366e796 fixed the same crash for
Errs that come up during handshake, but was incomplete and should
have just dropped the node_id being different based on
inbound/outbound. This patch does so and actually fixes the issue.
Found by fuzzer.