Improve network graph update logging #2498
Conversation
arik-so
force-pushed
the
arik/2023-08-gossip-logging
branch
2 times, most recently
from
da34c49 to
24c97f2
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2498 +/- ##
==========================================
+ Coverage 90.40% 90.94% +0.53%
==========================================
Files 106 106
Lines 56328 60767 +4439
Branches 56328 60767 +4439
==========================================
+ Hits 50926 55264 +4338
- Misses 5402 5503 +101
☔ View full report in Codecov by Sentry. |
arik-so
force-pushed
the
arik/2023-08-gossip-logging
branch
2 times, most recently
from
2243ba3 to
49daa85
Compare
lightning/src/routing/gossip.rs
Outdated
| @@ -1878,6 +1887,8 @@ impl<L: Deref> NetworkGraph<L> where L::Target: Logger { | |||
| } | |||
| } | |||
|
|
|||
| log_gossip!(self.logger, "Updating channel {} in direction {}", msg.short_channel_id, msg.flags & 1); | |||
There was a problem hiding this comment.
Can we at least include the timestamp in this log? Maybe also the disable/enable flag? Anything else that's important to know?
There was a problem hiding this comment.
Ah thought you were referring to the other log entrie wrt missing timestamps. No problem, will do. Sorry
arik-so
force-pushed
the
arik/2023-08-gossip-logging
branch
from
49daa85 to
d162c40
Compare
No description provided.