-
Notifications
You must be signed in to change notification settings - Fork 412
[WIP, POC] Tests for Interactive TX #2541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2541 +/- ##
==========================================
- Coverage 90.59% 90.50% -0.09%
==========================================
Files 110 111 +1
Lines 57410 57917 +507
Branches 57410 57917 +507
==========================================
+ Hits 52008 52416 +408
- Misses 5402 5501 +99
☔ View full report in Codecov by Sentry. |
Don’t hesitate to propose tests if they can be generalized out of LDK as test vectors addendum for lightning/bolts#851 There is a matrix of test cases with channel type, and I’m not even sure dual funding / splicing are fleshed enough on this. |
Patch coverage 76% -- with only a handful of tests and zero negative tests it seems to-good-to-be-true |
Closing for now, interactive TX code is still work-in-progress |
Based on: #2419
W-i-P, submitted to see tests & coverage.