Revert "Remove AvailableBalances::balance_msat" #2626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While removing the `balance_msat` field absolutely makes sense - it is, at best, confusing - we really need a solid replacement for it before we can do so. While one such replacement is in progress, it is not complete and we'd like to not block our current release on its completion. This reverts commit ef5be58.
dunxen
approved these changes
Sep 29, 2023
dunxen
approved these changes
Sep 29, 2023
G8XSU
approved these changes
Sep 29, 2023
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2626 +/- ##
=======================================
Coverage 89.00% 89.00%
=======================================
Files 112 112
Lines 86355 86365 +10
Branches 86355 86365 +10
=======================================
+ Hits 76857 76873 +16
+ Misses 7265 7257 -8
- Partials 2233 2235 +2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While removing the
balance_msatfield absolutely makes sense - it is, at best, confusing - we really need a solid replacement for it before we can do so. While one such replacement is in progress, it is not complete and we'd like to not block our current release on its completion.This reverts commit ef5be58.