Fix Simple*PeerManager to not require refs to the UtxoLookup
#2631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2631 +/- ##
==========================================
+ Coverage 89.10% 89.52% +0.41%
==========================================
Files 112 112
Lines 86932 90795 +3863
Branches 86932 90795 +3863
==========================================
+ Hits 77465 81283 +3818
- Misses 7239 7284 +45
Partials 2228 2228
☔ View full report in Codecov by Sentry. |
`UtxoLookup` doesn't strictly need to be referenced from the `PeerManager`, and in fact the new `GossipVerifier` in `lightning-block-sync` requires itself to be owned by the `PeerManager` (for circular type reasons). This allows us to use `lightning-block-sync`'s `GossipVerifier` with `SimpleArcPeerManager` in ldk-sample.
TheBlueMatt
force-pushed
the
2023-09-pm-no-refs-reqd
branch
from
e8aa190 to
6482635
Compare
jkczyz
reviewed
Oct 3, 2023
lightning/src/ln/peer_handler.rs
Outdated
| &'f P2PGossipSync<&'g NetworkGraph<&'f L>, &'h C, &'f L>, | ||
| &'i SimpleRefOnionMessenger<'g, 'm, 'n, L>, | ||
| &'j SimpleRefChannelManager<'a, 'b, 'c, 'd, 'e, 'f, 'g, 'i, M, T, F, L>, | ||
| &'f P2PGossipSync<&'g NetworkGraph<&'f L>, C, &'f L>, |
There was a problem hiding this comment.
Looks preexisting, but should we use different lifetime than 'f for P2PGossipSync given it uses that lifetime for its parameters?
jkczyz
previously approved these changes
Oct 3, 2023
tnull
previously approved these changes
Oct 3, 2023
jkczyz
previously approved these changes
Oct 3, 2023
Rather than simply a, b, c, d...we at least use names for a few things, also splitting the reused 'f lifetime.
TheBlueMatt
force-pushed
the
2023-09-pm-no-refs-reqd
branch
from
f72ca69 to
0b4bb24
Compare
jkczyz
approved these changes
Oct 3, 2023
wpaulino
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UtxoLookupdoesn't strictly need to be referenced from thePeerManager, and in fact the newGossipVerifierinlightning-block-syncrequires itself to be owned by thePeerManager(for circular type reasons).This allows us to use
lightning-block-sync'sGossipVerifierwithSimpleArcPeerManagerin ldk-sample.