Implement Readable/Writeable for RwLock wrappers #2632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now support separate R/W locks in `LockableScore`, which allow us to do routefinding in parallel, however in order to support `WriteableScore` for such users we need to implement `Writeable` for `RwLock` wrappers around `Writeable` types, which we do here.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2632 +/- ##
==========================================
- Coverage 89.09% 89.05% -0.05%
==========================================
Files 112 112
Lines 86932 86939 +7
Branches 86932 86939 +7
==========================================
- Hits 77456 77420 -36
- Misses 7246 7284 +38
- Partials 2230 2235 +5
☔ View full report in Codecov by Sentry. |
This switches the locks used around `ProbabilisticScorer` in `Simple*ChannelManager` type aliases to `RwLock`.
TheBlueMatt
force-pushed
the
2023-09-writeable-rwlock
branch
from
0d7c552 to
783e255
Compare
jbesraa
approved these changes
Oct 2, 2023
jkczyz
approved these changes
Oct 3, 2023
wpaulino
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support separate R/W locks in
LockableScore, which allowus to do routefinding in parallel, however in order to support
WriteableScorefor such users we need to implementWriteablefor
RwLockwrappers aroundWriteabletypes, which we do here.This is required to use
RwLockaroundProbabilisticScorerin ldk-sample.