Skip to content

Make test log lines somewhat more eye-scannable #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

When running tests, our log output should be reasonably readable by developers, but currently it repeats the module twice (via the module and file name), and then starts the log line at a variable location.

Instead, we only print the module and then align the start of the log lines so that the output is much more scannable.

When running tests, our log output should be reasonably readable
by developers, but currently it repeats the module twice (via the
module and file name), and then starts the log line at a variable
location.

Instead, we only print the module and then align the start of the
log lines so that the output is much more scannable.
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2c51080) 89.04% compared to head (ab21177) 89.03%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2665      +/-   ##
==========================================
- Coverage   89.04%   89.03%   -0.02%     
==========================================
  Files         112      112              
  Lines       87229    87231       +2     
  Branches    87229    87231       +2     
==========================================
- Hits        77674    77667       -7     
- Misses       7319     7329      +10     
+ Partials     2236     2235       -1     
Files Coverage Δ
lightning/src/util/test_utils.rs 77.14% <100.00%> (+0.05%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@valentinewallace valentinewallace merged commit 5fdc770 into lightningdevkit:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants