Folllow-ups to #2723 #2776
Merged
Folllow-ups to #2723 #2776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2776 +/- ##
==========================================
- Coverage 88.52% 88.51% -0.02%
==========================================
Files 115 115
Lines 90996 91008 +12
Branches 90996 91008 +12
==========================================
- Hits 80557 80556 -1
- Misses 8012 8022 +10
- Partials 2427 2430 +3 ☔ View full report in Codecov by Sentry. |
The name itself doesn't provide much meaning to what the addresses correspond to.
When enqueuing a message for a node already awaiting a connection, BufferedAwaitingConnection should be returned when a node is not yet connected as a peer. However, it was only returned when the first message was enqueued. Any messages enqueued after but before a connection was established incorrectly returned Buffered.
jkczyz
force-pushed
the
2023-12-direct-connect-follow-ups
branch
from
de435e8 to
1c4d328
Compare
shaavan
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
ACK
- The doc improvement looks good and clearly explains the function return values.
- Name change from
addresses->first_node_addressesgives it a better contextual meaning. - Different type of SendSuccess messages based on connection status makes sense and is nicely implemented.
TheBlueMatt
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback after merging #2723.