[Ready for Review] Add msgs serialization tests #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariard
changed the title
TheBlueMatt
reviewed
Jan 16, 2019
src/ln/msgs.rs
Outdated
| use secp256k1::{Secp256k1, Message}; | ||
|
|
||
| use rand::{Rng, thread_rng}; | ||
|
|
src/ln/msgs.rs
Outdated
|
|
||
| #[test] | ||
| fn test_serialization_bolt7_msgs() { | ||
|
|
ariard
force-pushed
the
2019-12-serialization-test
branch
from
b9f69f1 to
149821f
Compare
|
WIP, more in the way of already there encoding_announcement_signatures |
ariard
force-pushed
the
2019-12-serialization-test
branch
4 times, most recently
from
eaa82a2 to
282dac8
Compare
|
Rebased |
ariard
force-pushed
the
2019-12-serialization-test
branch
5 times, most recently
from
0272dcd to
931d8b0
Compare
ariard
changed the title
|
Good, tests for the 23 types of messages (bolt7 query-thing messages except) |
TheBlueMatt
reviewed
Feb 11, 2019
ariard
force-pushed
the
2019-12-serialization-test
branch
from
931d8b0 to
c5d730b
Compare
|
Hmm seems fail is due to travis issue, thread exists forcefully and first time I see these warnings : "Your glibc version:'2.19' will most likely result in malloc()-related deadlocks. Min. version 2.24 (Or, Ubuntu's 2.23-0ubuntu6) suggested. See https://sourceware.org/bugzilla/show_bug.cgi?id=19431 for explanation. Using clone() instead of fork()" ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.